Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenTracing Middleware Spans #273

Closed
mathewbyrne opened this issue Aug 8, 2018 · 1 comment
Closed

Fix OpenTracing Middleware Spans #273

mathewbyrne opened this issue Aug 8, 2018 · 1 comment

Comments

@mathewbyrne
Copy link
Contributor

Expected Behaviour

Prior to 0.4 Resolver Middlewares only ran for generated resolvers. With #217 this was changed to run for all fields in preparation for adding field directive support.

Actual Behavior

After 0.4 the OpenTracing middleware generates many more spans than it did previously. The middleware should be updated either to ran as it did previously, or be configurable.
@mathewbyrne
Copy link
Contributor Author

Looking at the code again, I'm not sure that this is a problem; I don't think it's been reported thus-far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathewbyrne