-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments not working in 0.4.4 #324
Comments
Believe the issue is somewhere around here: https://github.com/vektah/gqlparser/blob/master/parser/schema.go#L72 The comments are never set on the definition. |
Comments are ignored by the parser, descriptions are strings placed before the field or type: """ This is a description for Foo"""
type Foo {
}
# This is a comment, it does nothing.
type Bar {
} Upstream change is here graphql/graphql-js#927 |
@vektah Appears to be working for types and enum values, but not fields. Could we update the examples to show this? |
@andrewmunro as far as I can tell this is working for fields as well. Given the type:
I see: |
Confirmed working as intended. |
After our upgrade to 0.4.4, comments have stopped working.
Expected Behaviour
Comments should be viewable via the introspection API.
Actual Behavior
No comments are displayed for any fields or types.
Steps to reproduce
Run any of the examples in gqlgen. E.G Starwars:
The text was updated successfully, but these errors were encountered: