Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing: may I add .vscode development workflows? #17

Closed
strazto opened this issue Apr 21, 2022 · 2 comments
Closed

contributing: may I add .vscode development workflows? #17

strazto opened this issue Apr 21, 2022 · 2 comments

Comments

@strazto
Copy link
Collaborator

strazto commented Apr 21, 2022

To start developing on this project, I used vscode and wrote a few workflows, using the jellyfin-plugin-template as a reference

The workflows are fairly portable, and you can find them here:
https://github.com/matthewstrasiotto/jellyfin-plugin-sso/tree/main/.vscode

I accidentally checked them into my fork (oops) which I'll have to tidy up when it's time to pull, but I was wondering whether you'd accept development workflow artifacts into this project (on a separate pr)

@9p4
Copy link
Owner

9p4 commented Apr 21, 2022

I'd prefer it to keep platform-specific stuff out of the repo, but I would be open to putting something in the docs for platform-specific development options

@strazto
Copy link
Collaborator Author

strazto commented Apr 23, 2022

that's understandable. tbh it's definitely more appropriate in say, the template repo which i found fairly confusing.
My PR for #2 seems pretty much done, I'll make sure to clean up the PR to not include development artifacts, and I'll submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants