-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config in simple-run #288
Comments
There is no need to pas config file for |
Hey Sergey, well, that is in fact the problem. why do we have two separate execution methods instead of just allowing parameters to override the config? Ok, let me describe my situation here to justify my thinking as to why we need a new parameter: I am trying to run the application in a docker container now and I want to set the secret via an environment variable. However, I also want to increase the This combination means that I can not use I understand that some applications require complex configurations that can only be done by templating, but this app isn't really one of them. So I think that the simplest way to solve this inconvenience without breaking compatibility is to add a new config file parameter to |
When I've designed this app, my goal was to get rid of Go's way of passing myriads of cli arguments in a favor of a better-structured config file. I do not think it is a good idea to have overrides as cli parameters or environment variables because it will make both modes almost the same.
Will it work if I introduce a special syntax in config file that will take secret from envrionment variable? Like: secret = "-"
So, secret is going to be carved out from |
We need a way to pass a config file in
simple-run
or to pass the secret via the usualrun
at least.Otherwise, we end up having to implement every single config option as a parameter for
simple-run
.For example, I personally need
tolerate-time-skewness
while being able to pass at least the secret via the parameter. Currently, there is no way to do this.Least we can do is to have a default config file and read it regardless of the starting mode.
The text was updated successfully, but these errors were encountered: