Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Send ban notice to player on first join after their ban expires. #232

Open
1 task done
accLarson opened this issue Sep 8, 2023 · 3 comments
Open
1 task done
Labels
feature New feature or request

Comments

@accLarson
Copy link

I have confirmed that ...

  • There is no duplicate feature request.

Description

While many bans are given while the offender is online, many bans are also given to offline players.
It is currently possible to receive a ban while offline, for example a 5 day ban, and join the server again in 7 days (weekend warrior) and never know of the ban. If the player never knew about the ban, it's 0% effective as a deterrent for repeat offences; in their minds they haven't been caught yet.

I propose that when a player first connects after having been being banned, they should be sent a message indicating their ban. Maybe something like:

Welcome Back! You were banned for %REASON% on %START_DATE% for %DURATION%.

This message would be one time only and simply aims to ensure every banned players has a reasonable opportunity to know of their ban.

Thanks for reading! : )

@accLarson accLarson added the feature New feature or request label Sep 8, 2023
@SrBedrock
Copy link

I think it's a good idea to send a warning when the player enters after receiving a warning or if there is a warning in progress as well

@A248
Copy link
Owner

A248 commented Sep 9, 2023

One issue with implementing this feature is one can never really know whether a player received the message sent to them. The server doesn't provide guarantees that a chat message was sent; a player can connect and disconnect (thereby receiving any notifications) while the message is still in the pipeline. The player might even receive the message but disconnect within the same second, and thus not see it.

Such concerns matter when your purpose is to inform users of their punishments. If you set thr expectation that players will be automatically notified of their previous punishment, you might actually cause more trouble for the user who doesn't see the notification due to a quick disconnect; with such expectations, a fall through the cracks in the automatic notification system is potentially more likely to be overlooked than in the absence of automatic notifications.

If the player never knew about the ban, it's 0% effective as a deterrent for repeat offences; in their minds they haven't been caught yet.

I consider your purpose here, and I wonder if there is a different, even better, solution for deterrence. Perhaps you seek a kind of probation system, whereby players are notified if their current record is in murky waters rules-wise. Staff could mark players as under probation, and players would be notified on every join of their status, as opposed to just once. This could be further developed into a points-based probation system, although such a mechanism feels similar to warnings.

A similar idea, which might satisfy your needs, would be to send players their active warnings every time they join. If you want to deter past rulebreakers, ban them and set a warning that lasts for longer. With the LibertyBans API, automatically creating a complimentary warning to every ban requires only a few lines of code. Ultimately, I believe that tracking whether a player has received messages is ineffective, and that any notifications would be better sent on every join.

@accLarson
Copy link
Author

accLarson commented Sep 11, 2023

I see your concern with this feature however in my opinion I believe a simple notification on first login post ban would still be quite effective and simple.

You are right that there could be no certainty that the previously banned player would receive the message when logging in again however I feel its still worth implementing. The goal is not to have certainty of the ban notification being seen, but rather just providing a likely opportunity to notify about the ban. For slightly better results, delay the message until the player has been online for a configurable amount of seconds (3?) before sending; if they log off before that time, don't send it and delay till the next login. Another method of increasing likelihood of the message being seen would be a configurable count of login events (3?) for which the plugin would send the notification on.

Although your suggested ideas may work for some, they are not ideal for my case.

If you still have concerns with this feature, I have a secondary idea which would provide much more certainty in delivering the notification but would be far less "smooth". On a player's first login after their ban, immediately kick them with a customizable message. The key here is to ensure the message indicates they are no longer banned and can re-log immediately. I'd much rather the chat notification on login but a kick would likely satisfy your desire for guaranteed notifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants