Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring iOS platform implementation #245

Open
armandsLa opened this issue Mar 30, 2024 · 0 comments
Open

Refactoring iOS platform implementation #245

armandsLa opened this issue Mar 30, 2024 · 0 comments

Comments

@armandsLa
Copy link
Contributor

armandsLa commented Mar 30, 2024

The current iOS platform implementation doesn't follow common Swift best practices. It feels like it's written using Dart conventions, not Swift. Also, there are multiple unused variables, unsafe optional unwrapping, and 2-space indentation (Xcode's default is 4-space). All these things make it hard to work with the iOS side of things(using Xcode) and make PRs. This plugin would really benefit from a refactoring.

I could do this and make a PR, but before I do that, I would like to get confirmation that such a PR would be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant