Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a format checker before running the build #151

Open
ccarouge opened this issue Oct 24, 2024 · 0 comments
Open

Add a format checker before running the build #151

ccarouge opened this issue Oct 24, 2024 · 0 comments
Labels
type:feature New feature

Comments

@ccarouge
Copy link

There has been an issue with a branch name that contained "+". This tripped Spack.

It would be great to have a format checker running at the creation of the PR. The checker could indicate any issue found and possibly give a preferred branch name that is compatible with Spack.

I don't think we want the action to change the branch name on GitHub directly as it would break the pull/push with the local repo. Maybe we should give instructions of the commands to run locally if the name needs to be changed. I'm not sure how much we want to hand-hold people but we will always have contributors who are new to git.

@ccarouge ccarouge added the type:feature New feature label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant