Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer BIP353 over LNURL if found #589

Closed
Sjors opened this issue Jul 11, 2024 · 2 comments
Closed

Prefer BIP353 over LNURL if found #589

Sjors opened this issue Jul 11, 2024 · 2 comments

Comments

@Sjors
Copy link

Sjors commented Jul 11, 2024

Or at least, it would be nice to have this configurable.

Right now for sjors@sprovoost.nl it finds my NLURL instead of bolt12.

This was with iOs app version 2.3.0. It can pay to the (CLN generated) offer just fine if I paste it directly.

BIP353 has better privacy properties for the sender, so in the long run it should be preferred. But it's still new.

@dpad85
Copy link
Member

dpad85 commented Jul 12, 2024

This was with iOs app version 2.3.0.

You'll have to upgrade to version 2.3.1 -- the previous version can pay offers, but has no understanding of BIP353 and always tries to pay email-like address through the LNURL flow.

BIP353 is supported on Android 2.3.3+ and iOS 2.3.1+, and indeed Phoenix will always try BIP353 first, and will only fallback to LNURL if BIP353 fails. Though we should also have an option (opt-in) somewhere to never fallback to LNURL.

@Sjors
Copy link
Author

Sjors commented Jul 12, 2024

Ahh I tried too soon :-)

v2.3.1 iOs update appeared this morning for me!

Will let you know if doesn't work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants