Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: More Detailed Export #659

Open
lnbc1QWFyb24 opened this issue Dec 1, 2024 · 2 comments
Open

Feature: More Detailed Export #659

lnbc1QWFyb24 opened this issue Dec 1, 2024 · 2 comments

Comments

@lnbc1QWFyb24
Copy link

#337 added a CSV export which is super handy. I am building a Bitcoin accounting app and am working on a feature for Phoenix wallet imports of the CSV file that is currently exported, but it is missing some key information for good accounting. Our app attempts to track transfers between a users' various wallets so that we can accurately track when a transaction is an income / expense event vs a simple transfer between wallets. So it would be great if the following columns could be added to the export:

Lightning Receive and Send

  • payment invoice request (so the payment hash and other info can be extracted and for matching withdrawals from other services)

Onchain Receive and Send

  • Deposit address
  • Send address

I think the onchain send address might already be implemented, but I have not done a onchain send on my wallet yet to confirm.

@dpad85
Copy link
Member

dpad85 commented Dec 2, 2024

We should use the code made for phoenixd (the server version of Phoenix), see ACINQ/phoenixd#115

The Phoenixd version does contain the payment hash, though not on-chain details since phoenixd does not do on-chain payments, but that should be doable.

@lnbc1QWFyb24
Copy link
Author

Yeah thinking about it some more, for lightning payments we would only need the payment hash (rather than the request) since the description is already included in the export.
So if that is simple to copy over along with some extra logic to include the onchain addresses, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants