Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor leafletBlazorInterops #9

Open
maxreb opened this issue Dec 7, 2022 · 0 comments · May be fixed by #11
Open

Refactor leafletBlazorInterops #9

maxreb opened this issue Dec 7, 2022 · 0 comments · May be fixed by #11
Assignees
@aco-fwinzek
Labels
enhancement New feature or request

Comments

@maxreb
Copy link

maxreb commented Dec 7, 2022

leafletBlazorInterops.js is not ideal.
Things that should be considered:

  • Use DRY principle
  • Is a static C# interop class really the best idea? Shouldn't it be a internal class?
  • Should the options of the layer be in the layer itself as it is right now? See f.e. ImageLayer C# class. The options (like Opacity or zIndex) are within the ImageLayer class. Maybe it's better to have the .AddLayer method to include a ILayerOptions parameter.
  • More things to come...

Resources:
https://learn.microsoft.com/de-de/aspnet/core/blazor/javascript-interoperability/?view=aspnetcore-7.0
@maxreb maxreb added the enhancement New feature or request label Dec 7, 2022
@aco-fwinzek aco-fwinzek linked a pull request Jan 17, 2023 that will close this issue
feat: complete rewrite of static js interops file #11
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aco-fwinzek aco-fwinzek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: complete rewrite of static js interops file ACOAhlmann/ACO.Blazor.Leaflet
2 participants
@maxreb @aco-fwinzek