Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to swap item to the other side of a trade #570

Open
Valehead opened this issue Dec 9, 2021 · 1 comment
Open

Add ability to swap item to the other side of a trade #570

Valehead opened this issue Dec 9, 2021 · 1 comment

Comments

@Valehead
Copy link

Valehead commented Dec 9, 2021

Sometimes when trading I've seen users add cards to the wrong side of the trade interface. The only way to get this to the other side of the trade is to remove the item and then re-add it to the correct side.

Maybe make it a menu item when clicking on the card?

Or make it possible to long-touch the item to be able to pickup the object and physically move it to the other side?

Or (and this is the biggest stretch) add advanced functionality to the swiping option. Currently when you swipe left or right on a trade object it removes the card from the trade completely. If it's possible, you could make it so swiping towards the edge of the screen removes the item, and swiping towards the middle of the trade moves it to the opposite side.

E.g. if item on left side of trade, swiping left removes and swiping right changes side. If item on right side of trade, swiping right removes and swiping left changes side.

@AEFeinstein
Copy link
Owner

This ticket is somewhat covered by #513. To your options

Maybe make it a menu item when clicking on the card?

This is doable.

Or make it possible to long-touch the item to be able to pickup the object and physically move it to the other side?

Redoing the UI to make the entries physically movable is a big pain, and long-touch is already used for multi-select. That said, I'm comfortable with adding a 'swap sides' button to the long-press options, next to the trash icon

Or (and this is the biggest stretch) add advanced functionality to the swiping option. Currently when you swipe left or right on a trade object it removes the card from the trade completely. If it's possible, you could make it so swiping towards the edge of the screen removes the item, and swiping towards the middle of the trade moves it to the opposite side.

I like the creativity here, but a good UI needs to be consistent. Right now all the lists have 'swipe left to delete' and nothing for 'swipe right.' I don't think changing that behavior for one specific list (right trade) is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants