Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gsuite): add gsuite model #184

Merged
merged 5 commits into from
Dec 9, 2020
Merged

fix(gsuite): add gsuite model #184

merged 5 commits into from
Dec 9, 2020

Conversation

linuxbandit
Copy link
Member

NB this is merged into #183

some things are to check obviously as I am not aware of their correctness

@linuxbandit linuxbandit marked this pull request as draft November 22, 2020 21:56
WikiRik
WikiRik reviewed Nov 22, 2020
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions

models/User.js Show resolved Hide resolved
lib/constants.js Outdated Show resolved Hide resolved
migrations/20201025145040-add-gsuiteID-to-users.js Outdated Show resolved Hide resolved
migrations/20201027145040-add-gsuiteID-to-circles.js Outdated Show resolved Hide resolved
models/Circle.js Show resolved Hide resolved
@WikiRik WikiRik requested a review from LeonVreling November 22, 2020 23:00
@codecov
Copy link

codecov bot commented Nov 25, 2020 •
edited
Loading

Codecov Report

Merging #184 (62909b6) into master (01163bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1326      1329    +3     
  Branches       204       207    +3     
=========================================
+ Hits          1326      1329    +3
Impacted Files Coverage Δ
lib/constants.js 100.00% <ø> (ø)
models/Body.js 100.00% <100.00%> (ø)
models/Circle.js 100.00% <100.00%> (ø)
models/User.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01163bb...62909b6. Read the comment docs.

@WikiRik WikiRik requested review from WikiRik and removed request for WikiRik November 25, 2020 19:33
@WikiRik
Copy link
Member

WikiRik commented Nov 25, 2020

@serge1peshcoff @linuxbandit any clue on how to do the custom validation? Basically what I want is that it checks the uniqueness for all three (body, circle, user) before accepting it

@WikiRik WikiRik changed the base branch from feat/add-calls-to-gsuite-wrapper to master November 25, 2020 19:34
@WikiRik WikiRik changed the title feat: add gsuite model feat(gsuite): add gsuite model Nov 25, 2020
@WikiRik WikiRik changed the title feat(gsuite): add gsuite model fix(gsuite): add gsuite model Nov 25, 2020
@WikiRik WikiRik marked this pull request as ready for review November 26, 2020 13:27
@WikiRik
Copy link
Member

WikiRik commented Nov 26, 2020

I'm moving the custom validation to #183

@WikiRik WikiRik requested a review from a team November 26, 2020 16:56
@WikiRik WikiRik mentioned this pull request Nov 29, 2020
Merged
@WikiRik WikiRik requested review from WikiRik and removed request for WikiRik November 29, 2020 22:35
@WikiRik
Copy link
Member

WikiRik commented Dec 8, 2020

@serge1peshcoff @linuxbandit @LeonVreling I guess we can merge this already right? It would not cause any errors

@WikiRik WikiRik force-pushed the feat/add-gsuite-model branch from 3f6144e to 62909b6 Compare December 9, 2020 19:31
@WikiRik WikiRik merged commit d5c5534 into master Dec 9, 2020
@WikiRik WikiRik deleted the feat/add-gsuite-model branch December 9, 2020 19:40
serge1peshcoff pushed a commit that referenced this pull request Dec 9, 2020
@semantic-release-bot
chore(release): 1.31.1 [skip ci]
4b1e378 
## [1.31.1](1.31.0...1.31.1) (2020-12-09)

### Bug Fixes

* **gsuite:** add gsuite model ([#184](#184)) ([d5c5534](d5c5534))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik left review comments

@LeonVreling LeonVreling LeonVreling approved these changes

@serge1peshcoff serge1peshcoff Awaiting requested review from serge1peshcoff

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linuxbandit @WikiRik @serge1peshcoff @LeonVreling