fix(members): change getUser for event creation #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Members now have the global:view_members:body permission to add organizers from other locals, with this change we also store the correct information when storing the event
|
@serge1peshcoff what do you think of this solution? I don't want all members to access other profiles just yet but with this they only retrieve the information needed to add them as organizer. No further changes in frontend/summeruniversity are needed. |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1333 1335 +2
Branches 209 210 +1
=========================================
+ Hits 1333 1335 +2
Continue to review full report at Codecov.
|
serge1peshcoff
pushed a commit
that referenced
this pull request
Feb 13, 2021
## [1.31.6](1.31.5...1.31.6) (2021-02-13) ### Bug Fixes * **members:** change getUser for event creation ([#232](#232)) ([20c01c3](20c01c3))
|
🎉 This PR is included in version 1.31.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Members now have the global:view_members:body permission to add organizers from other locals, with this change we also store the correct information when storing the event