fix(bodies): replace SHOULD with MUST for mandatory requirements #414
Conversation
Remove default: '' for values, which must not be empty. Emails must not be empty. CLE, MHW, ZRH have no emails.
|
Thanks for the PR! I have reconfigured CircleCI so it should do checks from forks as well, but I'm not sure when it kicks in unfortunately. |
There was a problem hiding this comment.
Changes look good and are a good start for further refactoring.
Looking at this again I don't know why task_description needs a default value and why phone and address must be set as it's allowed to be null (which is also the behaviour we want). So I'll take a look at that soon as it's easy refactoring and a good moment to check the tests. Will then also replace SHOULD with MUST in the other models. Other modules of MyAEGEE will also get those refactoring updates later
WikiRik
changed the title
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1435 1435
Branches 231 231
=========================================
Hits 1435 1435
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Update https://github.com/dilyanpalauzov/core/blob/should_must/test/unit/bodies.test.js#L109 and tests should pass if I recall correctly
## [1.36.10](1.36.9...1.36.10) (2021-12-28) ### Bug Fixes * **bodies:** replace SHOULD with MUST for mandatory requirements ([#414](#414)) ([f0a1211](f0a1211))
|
🎉 This PR is included in version 1.36.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Remove default: '' for values, which must not be empty.
Emails must not be empty. CLE, MHW, ZRH have no emails.