Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): add handling of Antenna Criteria #662

Merged
merged 16 commits into from
Sep 15, 2024
Merged

feat(network): add handling of Antenna Criteria #662

merged 16 commits into from
Sep 15, 2024

Conversation

LeonVreling
Copy link
Member

Needed for frontend/#2036

@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.08%. Comparing base (3135bd6) to head (6b64aed).
Report is 2 commits behind head on stable.

Files with missing lines Patch % Lines
lib/antenna_criteria.js 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           stable     #662      +/-   ##
==========================================
- Coverage   98.26%   98.08%   -0.19%     
==========================================
  Files          13       15       +2     
  Lines         288      313      +25     
  Branches       47       51       +4     
==========================================
+ Hits          283      307      +24     
- Misses          5        6       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik
WikiRik reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the permissions

WikiRik
WikiRik approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good for now. We likely will do follow up based on the feedback of NetCom and further work we do to automate more checks

@WikiRik WikiRik changed the title feat(network): Add handling of Antenna Criteria feat(network): add handling of Antenna Criteria Sep 15, 2024
@WikiRik WikiRik merged commit 7bd43e1 into stable Sep 15, 2024
5 of 7 checks passed
@WikiRik WikiRik deleted the add-ac-handling branch September 15, 2024 18:37
serge1peshcoff pushed a commit that referenced this pull request Sep 15, 2024
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
ae26340 
# [1.2.0](1.1.3...1.2.0) (2024-09-15)

### Features

* **network:** add handling of Antenna Criteria ([#662](#662)) ([7bd43e1](7bd43e1))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeonVreling @serge1peshcoff @WikiRik