fix(integration): integration code is unique now

AEGEE · Apr 28, 2019 · d2a795c · d2a795c
1 parent eb92584
commit d2a795c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/migrations/20190427100249-create-integration.js b/migrations/20190427100249-create-integration.js
@@ -12,7 +12,8 @@ module.exports = {
  },
  code: {
  type: Sequelize.STRING,
- allowNull: false
+ allowNull: false,
+ unique: true
  },
  quota_period: {
  type: Sequelize.STRING,

diff --git a/models/Integration.js b/models/Integration.js
@@ -16,6 +16,10 @@ const Integration = sequelize.define('integration', {
  validate: {
  notEmpty: { msg: 'Integration code should be set.' },
  },
+ unique: {
+ args: true,
+ msg: 'Integration code is already taken.'
+ }
  },
  quota_period: {
  type: Sequelize.STRING,

diff --git a/test/api/integrations-creation.test.js b/test/api/integrations-creation.test.js
@@ -127,4 +127,19 @@ describe('Integrations creation', () => {
  expect(res.body).toHaveProperty('errors');
  expect(res.body.errors).toHaveProperty('quota_period');
  });
+
+ test('should fail if the code is taken already', async () => {
+ await generator.createIntegration({ code: 'test' });
+ const res = await request({
+ uri: '/integrations',
+ method: 'POST',
+ headers: { 'X-Auth-Token': 'blablabla' },
+ body: generator.generateIntegration({ code: 'test' })
+ });
+
+ expect(res.statusCode).toEqual(422);
+ expect(res.body.success).toEqual(false);
+ expect(res.body).toHaveProperty('errors');
+ expect(res.body.errors).toHaveProperty('code');
+ });
 });