Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(question line): Updated ID of question line #387

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix(question line): Updated ID of question line #387

merged 1 commit into from
Jun 2, 2020

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Jun 1, 2020

Formerly the ID of the question line was the internal ID, which did not reset with every Agora. Now the ID will just be the index + 1.

Formerly the ID of the question line was the internal ID, which did not reset with every Agora. Now the ID will just be the index + 1.
Copy link
Member

@serge1peshcoff serge1peshcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check out if it works? if yes, seems okay

@WikiRik
Copy link
Member Author

WikiRik commented Jun 1, 2020

No, getting things to update properly on my local machine is still a mess. But I copied the text from the bit of code that deals with displaying the actual questions, so in theory it should work

@serge1peshcoff serge1peshcoff merged commit 5fb9e3c into AEGEE:master Jun 2, 2020
serge1peshcoff pushed a commit that referenced this pull request Jun 2, 2020
## [0.45.9](0.45.8...0.45.9) (2020-06-02)

### Bug Fixes

* **question line:** Updated ID of question line ([#387](#387)) ([5fb9e3c](5fb9e3c))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 0.45.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants