You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I could tell from a quick search most Command invocations in build.rs files only use a single unwrap on the result of the status(). However, the first unwrap only covers a failure to invoke the command, not whether it completed successfully.
Mara Bos has confirmed this in this comment.
To Reproduce
Steps to reproduce the behavior:
Don't install a required dependency to build qemu
Run cargo build --no-default-features -p libafl_qemu
Observe that the first error reported by the build script is Failed to read linkinfo.json as that is the "observable" error condition from the perspective of the build script.
Expected behavior
I would expect the error to be accurately attributed to the failing command.
Additional context
There are a couple of different ways this is handled in other buildscripts
Describe the bug
As far as I could tell from a quick search most
Command
invocations inbuild.rs
files only use a singleunwrap
on the result of thestatus()
. However, the first unwrap only covers a failure to invoke the command, not whether it completed successfully.Mara Bos has confirmed this in this comment.
To Reproduce
Steps to reproduce the behavior:
cargo build --no-default-features -p libafl_qemu
Failed to read linkinfo.json
as that is the "observable" error condition from the perspective of the build script.Expected behavior
I would expect the error to be accurately attributed to the failing command.
Additional context
There are a couple of different ways this is handled in other buildscripts
LibAFL/libafl_libfuzzer/build.rs
Lines 79 to 82 in 374f873
LibAFL/libafl_nyx/build.rs
Lines 10 to 14 in 374f873
But there are also a lot of unhandled cases elsewhere like
LibAFL/fuzzers/backtrace_baby_fuzzers/forkserver_executor/build.rs
Lines 26 to 30 in 374f873
LibAFL/libafl_frida/build.rs
Lines 31 to 33 in 374f873
The text was updated successfully, but these errors were encountered: