Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up lookup table calculation #39

Open
2 of 3 tasks
aetherspritee opened this issue Apr 7, 2024 · 3 comments
Open
2 of 3 tasks

Speed up lookup table calculation #39

aetherspritee opened this issue Apr 7, 2024 · 3 comments
Assignees

Comments

@aetherspritee
Copy link
Collaborator

aetherspritee commented Apr 7, 2024

  • Rewrite main routine to use a single for loop
  • Persist data after calculation and load it from file, since it only depends on lmax
  • Overwrite persisted data if data for larger lmax is calculated, only load the required entries from it when using smaller lmax
@aetherspritee
Copy link
Collaborator Author

Loading and persisting data is working on 94fe587. I have a fortran script too, but i dont think its necessary given how lmax really doesnt ever need to change.

Will merge onto main in coming days

@arunoruto
Copy link
Contributor

After merging #41 the tests are running without any issue.
The coverage report regarding the numerics file can be viewed here.

@arunoruto
Copy link
Contributor

The commit 56074be shortens the for loops from 7 to 2 and introduces an additional flag for the computation to be forced, instead of loading the data from the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants