Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from setup.py test and use a better alternative #75

Open
6 tasks
fridex opened this issue Nov 2, 2020 · 6 comments
Open
6 tasks

Move away from setup.py test and use a better alternative #75

fridex opened this issue Nov 2, 2020 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@fridex
Copy link
Contributor

fridex commented Nov 2, 2020

Is your feature request related to a problem? Please describe.

It would be great if we move away from setup.py test command used to trigger unit tests. As an alternative, we could use nox or tox (used in many Python communities).

Describe the solution you'd like

Have a solution that seamlessly integrates with Pipfile and does not require maintaining setup.py (some components does not need it at all).

Let's have a spike which tooling can be used to trigger and maintain the testsuite:

  • check tox
  • check nox
  • come up with a sample repo that triggers the testsuite using nox
  • come up with a sample repo that triggers the testsuite using tox
  • make sure the sample repo uses Pipfile and respects its dev dependencies that are required to be installed when running the testsuite
  • think about possibly abstracting away the configuration (moving it to CI) so that users do not need to provide tox/nox config file for triggering the testsuite (unless they want to override the default behavior)

References

@harshad16
Copy link
Member

Thanks for such a descriptive issue.

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Feb 9, 2021
@sesheta
Copy link
Contributor

sesheta commented Jul 3, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2021
@harshad16
Copy link
Member

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2021
@sesheta
Copy link
Contributor

sesheta commented Oct 16, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2021
@sesheta
Copy link
Contributor

sesheta commented Nov 15, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2021
@harshad16
Copy link
Member

/lifecycle frozen

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants