Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podio-vis not installed by make install #501

Closed
wdconinc opened this issue Oct 7, 2023 · 2 comments · Fixed by #503
Closed

podio-vis not installed by make install #501

wdconinc opened this issue Oct 7, 2023 · 2 comments · Fixed by #503

Comments

@wdconinc
Copy link
Contributor

wdconinc commented Oct 7, 2023

  • OS version: ubuntu 23.04
  • Compiler version: gcc 12.3.0
  • PODIO version: master
  • Reproduced by: cmake -Bbuild -S. && make -Cbuild install
  • Goal: While podio-dump from tools/ is installed by the CMakeLists.txt in that directory, podio-vis is not installed. This makes it impossible to use podio-vis unless you keep the source tree around and use it from there.
@tmadlener
Copy link
Collaborator

Good catch, (and also it looks like it is actually used). Do you want to add it here?

install(PROGRAMS ${CMAKE_CURRENT_LIST_DIR}/podio-dump DESTINATION ${CMAKE_INSTALL_BINDIR})

Otherwise, I will try to pick this up next week (remind me in case I forget).

@wdconinc
Copy link
Contributor Author

wdconinc commented Oct 7, 2023

Yeah I'll add it and put in a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants