Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a problem about StandardScaler #482

Open
gayo66 opened this issue Dec 22, 2021 · 1 comment
Open

Have a problem about StandardScaler #482

gayo66 opened this issue Dec 22, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@gayo66
Copy link

gayo66 commented Dec 22, 2021

Thanks for your code which helps me a lot.
And I want to ask a question about StandardScaler:
When creating a data loader, shouldn't the mean and standard deviation of the training set be used for validation and test set standardization?
I see in the code that the validation set uses the mean and standard deviation of the validation set, and the test set uses the mean and standard deviation of the test set.
Hope for your reply. Thanks!

@isaacmg isaacmg added the bug Something isn't working label Dec 24, 2021
@isaacmg
Copy link
Collaborator

isaacmg commented Dec 24, 2021

Yeah it probably should in general as good practice. Most of the datasets historically we/others have used though have had similar distributions so it hasn't really affected things. But we will probably fix in an upcoming PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants