-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http Transport uses JSON format options as request options #1732
Http Transport uses JSON format options as request options #1732
Comments
also running into this issue... seems to be something wrong here: https://github.com/winstonjs/winston/blob/master/lib/winston/transports/http.js#L182-L183 |
PR is welcomed, if you identify a bug and can include some unit tests in a PR! |
I opened a PR, i dont think its perfect but it fixes the issue as far as I can tell @DABH |
Going to close this issue since we've merged the PR (this fix will go out in the next release, which should probably be a minor release 3.2.0). Thanks for your contribution! |
Please tell us about your environment:
winston
version?winston@2
winston@3
node -v
outputs: v13.1.0What is the problem?
If I use a property in a JSON formatted log which has the same name as an option in the configuration of the Http Transport its used as an option there (See Example Code).
What do you expect to happen instead?
I do expect that the contents of
<logger>.log()
directly go the logging transport and do not interfere with the transport configuration.Example Code
Example Code Output
The text was updated successfully, but these errors were encountered: