Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build OVMF firmware due to missing Subhook dependency #251

Open
secretfader opened this issue Dec 4, 2024 · 3 comments
Open

Comments

@secretfader
Copy link

secretfader commented Dec 4, 2024

It seems the version of edk2 used by this project has a Git submodule that was unpublished:

Cloning into '/home/nicholas/git/amdsev/ovmf/UnitTestFrameworkPkg/Library/SubhookLib/subhook'... 
remote: Repository not found.
fatal: Authentication failed for 'https://github.com/Zeex/subhook.git/'
fatal: clone of 'https://github.com/Zeex/subhook.git' into submodule path '/home/nicholas/git/amdsev/ovmf/UnitTestFrameworkPkg/Library/SubhookLib/subhook' failed
Failed to clone 'UnitTestFrameworkPkg/Library/SubhookLib/subhook'. Retry scheduled

There is a mirror of Subhook located at https://github.com/tianocore/edk2-subhook, but the original repo, along with the Zeex's other repos, has been removed from GitHub and is no longer public.

@Garandor
Copy link

Garandor commented Dec 4, 2024

note that this is fixed on EDK2 master since tianocore/edk2#6402 (which makes it use the mirror @secretfader referenced above)

Will this need a change in AMDSEV to make use of the new EDK2 master?

@lorenzobrescia
Copy link

Is there an easy way to resolve it?

In my case the command ./build.sh ovmf is prompting me credentials that I have not in order to cloning into '/home/ubuntu/AMDSEV/ovmf/UnitTestFrameworkPkg/Library/SubhookLib/subhook'

@tlendacky
Copy link
Collaborator

You can either update delete the ovmf directory so that the latest version of the repo is cloned or do a git rm -rf UnitTestFrameworkPgk/ from the ovmf directory (I think that should work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants