Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials don't build with MSVC + CUDA #1639

Closed
robertmaynard opened this issue Dec 14, 2020 · 1 comment
Closed

Tutorials don't build with MSVC + CUDA #1639

robertmaynard opened this issue Dec 14, 2020 · 1 comment

Comments

@robertmaynard
Copy link
Contributor

The AMReX transformation of C++ CMake properties to CUDA properties causes them all to become PRIVATE properties. Therefore the /experimental:preprocessor or /Zc:preprocessor flags aren't properly propagated to consumers.

Any preferences on how best to resolve this @ax3l?

@ax3l
Copy link
Member

ax3l commented May 17, 2021

I think that's now fixed and #1585 adds CI for it.

Xref: #1773 #1593 #1009

@ax3l ax3l closed this as completed May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants