[feat] 6주차 과제 #10
Open
[feat] 6주차 과제 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t1nm1ksun
requested review from
chattymin,
tunaunnie,
jihyunniiii and
angryPodo
and removed request for
a team
chattymin
reviewed
Dec 1, 2024
| @@ -5,8 +5,9 @@ plugins { | |||
| alias(libs.plugins.kotlin.android) | |||
| alias(libs.plugins.kotlin.compose) | |||
| alias(libs.plugins.kotlin.serialization) | |||
| alias(libs.plugins.dagger.hilt) | |||
| id("org.jetbrains.kotlin.kapt") | |||
There was a problem hiding this comment.
ksp 써보쉴?
kapt와 ksp의 차이점, ksp의 장점은 아실테니 한번 해보시면 좋을거같아요~
| import org.sopt.and.data.dataremote.model.request.RequestSignUpDto | ||
| import org.sopt.and.data.dataremote.model.response.ResponseSignUpDto | ||
| import org.sopt.and.domain.repository.UserRepository | ||
| import retrofit2.Response |
There was a problem hiding this comment.
domain에 retrofit 의존성이 들어있네용!
빼주시면 좋을거같아요~
| @@ -3,4 +3,5 @@ plugins { | |||
| alias(libs.plugins.android.application) apply false | |||
| alias(libs.plugins.kotlin.android) apply false | |||
| alias(libs.plugins.kotlin.compose) apply false | |||
| id("com.google.dagger.hilt.android") version "2.52" apply false | |||
angryPodo
reviewed
Dec 8, 2024
| @@ -5,8 +5,9 @@ plugins { | |||
| alias(libs.plugins.kotlin.android) | |||
| alias(libs.plugins.kotlin.compose) | |||
| alias(libs.plugins.kotlin.serialization) | |||
| alias(libs.plugins.dagger.hilt) | |||
| id("org.jetbrains.kotlin.kapt") | |||
There was a problem hiding this comment.
나도 kapt썻다가 ksp썻다가...ksp로 나중에 오류 잡아서 고쳐보자!
angryPodo
reviewed
Dec 8, 2024
| userRemoteDataSource.postSignup(requestSignUpDto) | ||
|
|
||
| override suspend fun postLogin(requestLoginDto: RequestLoginDto): Response<ResponseLoginDto> = | ||
| userRemoteDataSource.postLogin(requestLoginDto) |
There was a problem hiding this comment.
Response 타입을 그대로 반환하는데, 도메인 레이어에서 더 사용하기 좋은 형태(Result나 sealed class)로 매핑하는게 더 좋다고 들었는데 어떤가요?
angryPodo
reviewed
Dec 8, 2024
| loggingInterceptor: HttpLoggingInterceptor | ||
| ): OkHttpClient = | ||
| OkHttpClient.Builder().apply { | ||
| connectTimeout(10, TimeUnit.SECONDS) |
tunaunnie
approved these changes
Dec 8, 2024
|
|
||
| class UserInfoLocalDataSourceImpl(context: Context) : UserInfoLocalDataSource { | ||
| class UserLocalDataSourceImpl @Inject constructor( |
There was a problem hiding this comment.
LocalDataSource에 대해서 찾아봤는데 실제로 개발할 때 사용하기 엄청 유용할 것 같더라고요..! 길지 않은 시간 동안 무겁지 않은 정보를 저장하고 싶을 때 유용하게 쓸 것 같아요!!
| @@ -1,4 +1,4 @@ | |||
| package org.sopt.and.domain | |||
| package org.sopt.and.domain.model | |||
|
|
|||
| data class User( | |||
There was a problem hiding this comment.
여기에다가 hobby, token을 한번에 관리하지 않고 다 다른 데이터 클래스에 분리해두는 이유가 뭔가요??
| import dagger.hilt.android.HiltAndroidApp | ||
|
|
||
| @HiltAndroidApp | ||
| class WavveApp : Application() |
There was a problem hiding this comment.
Hilt를 쓰니까 @HiltAndroidApp 어노테이션이 없으면 빌드 에러가 나더라구요...? 힐트를 써줄때면 이렇게 어플리케이션을 늘 하나 따로 만들어서 androidmanifest.xml 파일에도 등록해줘야 하는 건가요?! 뭔가 프로젝트 안에 동떨어진 WaveApp.kt 파일이 하나 생기는 게 조금 이질적으로 느껴져서 여쭤봅니다 ㅜㅜ
angryPodo
approved these changes
Dec 8, 2024
jihyunniiii
reviewed
Dec 16, 2024
Comment on lines
+2
to
+3
|
|
||
|
|
Comment on lines
+9
to
+10
|
|
||
|
|
Comment on lines
+42
to
+47
| addInterceptor { chain -> | ||
| val request = chain.request().newBuilder() | ||
| .addHeader("Accept", "*/*") | ||
| .build() | ||
| chain.proceed(request) | ||
| } |
| package org.sopt.and.domain.model | ||
|
|
||
| data class Hobby( | ||
| var hobby: String = "", |
| @@ -0,0 +1,5 @@ | |||
| package org.sopt.and.domain.model | |||
|
|
|||
| data class Token( | |||
Comment on lines
+3
to
+4
| import org.sopt.and.data.dataremote.model.request.RequestLoginDto | ||
| import org.sopt.and.data.dataremote.model.response.ResponseLoginDto |
| @@ -0,0 +1,15 @@ | |||
| package org.sopt.and.domain.usecase | |||
|
|
|||
| import org.sopt.and.data.dataremote.model.response.ResponseMyHobbyDto | |||
| import org.sopt.and.data.datalocal.datasource.UserInfoLocalDataSource | ||
| import org.sopt.and.data.service.RetrofitInstance.userService | ||
| import org.sopt.and.domain.User | ||
| import org.sopt.and.data.datalocal.datasource.UserLocalDataSource |
Comment on lines
+13
to
+14
| import org.sopt.and.data.dataremote.model.request.RequestLoginDto | ||
| import org.sopt.and.data.dataremote.model.response.ResponseFailedDto |
Comment on lines
-13
to
+12
| import org.sopt.and.domain.User | ||
| import org.sopt.and.data.dataremote.model.request.RequestSignUpDto | ||
| import org.sopt.and.data.dataremote.model.response.ResponseFailedDto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
변경사항 없습니다
Uncompleted Tasks 😅
To Reviewers 📢