Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last layer_size entry in a1lx is redundant #140

Closed
tdaede opened this issue Mar 25, 2021 · 1 comment · Fixed by #143
Closed

Last layer_size entry in a1lx is redundant #140

tdaede opened this issue Mar 25, 2021 · 1 comment · Fixed by #143

Comments

@tdaede
Copy link
Contributor

tdaede commented Mar 25, 2021

The last layer size can simply be inferred to be the entire Item size.

Not only does this shrink layer_size to only 3 entries, but by not coding the largest layer size it makes it much more likely to be coded as a u16, saving up to 10 bytes in the best case.

@leo-barnes
Copy link
Collaborator

I'll hold off on #131 until we've decided since it's using the a1lx box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants