Skip to content

fix(docs): Replaced favicon with transparent icon (#446) #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulharpal1603 merged 1 commit into from
Jul 6, 2025
Merged

fix(docs): Replaced favicon with transparent icon (#446) #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ edit_uri: edit/main/docs/

theme:
name: material
logo: assets/PictoPy-logo.png
favicon: assets/PictoPy-logo.png
logo: assets/favicon.png
favicon: assets/favicon.png
Comment on lines +8 to +9
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Logo & favicon now point to the same 32×32-style asset—double-check visual quality

Switching the logo reference from the full-sized PictoPy-logo.png to the (typically small) favicon.png may cause the top-left site brand to look pixelated or off-center.
Unless the new PNG was exported at logo-grade resolution, keep the original logo and change only the favicon.

-  logo: assets/favicon.png
-  favicon: assets/favicon.png
+  # keep high-resolution logo, use transparent favicon only for the tab icon
+  logo: assets/PictoPy-logo.png
+  favicon: assets/favicon.png

🏁 Script executed:

#!/bin/bash
# 1. Ensure the high-res logo still exists
fd PictoPy-logo.png docs || echo "⚠️  PictoPy-logo.png missing"

# 2. Check for other references that still expect the old logo path
rg -n 'PictoPy-logo\.png' -A1 -B1

# 3. Confirm the new favicon actually landed in the expected location
fd favicon.png docs/assets || echo "⚠️  favicon.png missing in docs/assets"

Length of output: 290

Restore high-resolution logo and retain favicon for the tab icon

We’ve confirmed that docs/assets/PictoPy-logo.png still exists and docs/assets/favicon.png is in place. To preserve branding quality, switch only the favicon reference and keep the original logo:

• File: mkdocs.yml (lines 8–9)

-  logo: assets/favicon.png
-  favicon: assets/favicon.png
+  logo: assets/PictoPy-logo.png
+  favicon: assets/favicon.png
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
logo: assets/favicon.png
favicon: assets/favicon.png
logo: assets/PictoPy-logo.png
favicon: assets/favicon.png
🤖 Prompt for AI Agents 
In mkdocs.yml around lines 8 to 9, the logo is currently set to a low-resolution
favicon image. Change the logo path back to docs/assets/PictoPy-logo.png to
restore the high-resolution logo, while keeping the favicon path as
docs/assets/favicon.png to retain the tab icon.

icon:
repo: fontawesome/brands/github
features:
Expand Down
Loading