Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mag6t.ramp_button and .switch_heater to PVPositioner #100

Open
gfabbris opened this issue Mar 24, 2021 · 1 comment
Open

Convert mag6t.ramp_button and .switch_heater to PVPositioner #100

gfabbris opened this issue Mar 24, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gfabbris
Copy link
Contributor

One difficulty in this problem is that in each step we want to wait for certain conditions. For example, in the staging process, we first click on the ramp button, then wait for the supply current to match the magnet current, then turn on the switch heater, then wait for the magnet status to change. Currently this is done in a workaround, using the SetSignal that simply returns a subscription status based on an input device and function (Codacy doesn't like SetSignal). Then using abs_set (with wait=True) we can make the RunEngine wait for each step to complete.

I suspect the "best" way to do this is by converting .ramp_button and .switch_heater into PVPositioner. I will try to do it later, for now we can just leave it as is.

Originally posted by @gfabbris in #99 (comment)

@gfabbris gfabbris self-assigned this Mar 26, 2021
@gfabbris gfabbris added the enhancement New feature or request label Mar 26, 2021
@gfabbris
Copy link
Contributor Author

gfabbris commented Aug 2, 2021

Looked into this further and couldn't identify ways to do this better. Converting the ramp_button and switch_heater to PVPositioner isn't trivial, and doesn't help too much as they depend on things like the current difference, or magnet status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant