You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One difficulty in this problem is that in each step we want to wait for certain conditions. For example, in the staging process, we first click on the ramp button, then wait for the supply current to match the magnet current, then turn on the switch heater, then wait for the magnet status to change. Currently this is done in a workaround, using the SetSignal that simply returns a subscription status based on an input device and function (Codacy doesn't like SetSignal). Then using abs_set (with wait=True) we can make the RunEngine wait for each step to complete.
I suspect the "best" way to do this is by converting .ramp_button and .switch_heater into PVPositioner. I will try to do it later, for now we can just leave it as is.
Looked into this further and couldn't identify ways to do this better. Converting the ramp_button and switch_heater to PVPositioner isn't trivial, and doesn't help too much as they depend on things like the current difference, or magnet status.
One difficulty in this problem is that in each step we want to wait for certain conditions. For example, in the staging process, we first click on the ramp button, then wait for the supply current to match the magnet current, then turn on the switch heater, then wait for the magnet status to change. Currently this is done in a workaround, using the
SetSignal
that simply returns a subscription status based on an input device and function (Codacy doesn't likeSetSignal
). Then usingabs_set
(withwait=True
) we can make theRunEngine
wait for each step to complete.I suspect the "best" way to do this is by converting
.ramp_button
and.switch_heater
intoPVPositioner
. I will try to do it later, for now we can just leave it as is.Originally posted by @gfabbris in #99 (comment)
The text was updated successfully, but these errors were encountered: