Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of fluorescence scans by load_absorption #35

Open
gfabbris opened this issue Feb 23, 2021 · 0 comments
Open

Improve handling of fluorescence scans by load_absorption #35

gfabbris opened this issue Feb 23, 2021 · 0 comments

Comments

@gfabbris
Copy link
Contributor

A few ideas:

  • Change transmission kwarg to fluo.
  • Add default detectors for fluorescence. May be able to do some of this by looking at the detectors used in the scan.
  • Add and ROI kwarg? This would be used only if default detectors were used. It would simplify picking the ROI without having to enter a 'detector'
  • Create a separate "load_fluorescence" and "load_transmission" functions? It may be the cleaner way to do this. Otherwise a lot of logic might need to go into load_absorption.
  • Ultimately, we might want to just read the positioner, detector and monitor from the hints metadata. But we will need to be sure that it is properly done in our scans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant