Skip to content

Component type of icon prop type support #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngxiaoyi opened this issue Apr 17, 2017 · 1 comment
Open

Component type of icon prop type support #20

ngxiaoyi opened this issue Apr 17, 2017 · 1 comment

Comments

@ngxiaoyi
Copy link

ngxiaoyi commented Apr 17, 2017

Hi there,

If this component plugin depends on the font - FontAwesome which comes from the repository : react-native-vector-icons. Why not support component type for the 'icon' prop directly?

eg:

import ItemCell from 'react-native-item-cell';
import Icon from 'react-native-vector-icons/FontAwesome';
<ItemCell
icon={<Icon name="rocket"/>}
>
Item
</ItemCell>

#just a feature wanted

@ngxiaoyi
Copy link
Author

Filed a PR: #21

Please have a review and fell free to handle it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant