Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cannot install arm-pyart 1.18.5 on macOS (arm64) #1602

Closed
neutrinoceros opened this issue Jun 25, 2024 · 12 comments · Fixed by #1606
Closed

BUG: Cannot install arm-pyart 1.18.5 on macOS (arm64) #1602

neutrinoceros opened this issue Jun 25, 2024 · 12 comments · Fixed by #1606

Comments

@neutrinoceros
Copy link
Contributor

  • Py-ART version: 1.18.5
  • Python version: 3.12.4
  • Operating System: macOS

Description

Trying to instal the package in a fresh venv on this arch errors as

$ python -m pip install arm-pyart
...
ERROR: arm-pyart has an invalid wheel, arm-pyart has an invalid wheel, could not read 'arm_pyart-1.18.5.dist-info/WHEEL' file: BadZipFile("Bad CRC-32 for file 'arm_pyart-1.18.5.dist-info/WHEEL'")

version 1.18.4 still installs correctly

@mgrover1
Copy link
Collaborator

@neutrinoceros - the conda-forge wheels pass, as well as installing locally on my Mac... do you have more info about the machine that is having issues?

@neutrinoceros
Copy link
Contributor Author

I discovered this in yt's CI (example logs), but I was also able to reproduce locally.
In case that's useful, here are my specs:

  • macOS 14.5
  • chip: M2 Pro

I tried it with pip 24.1, 24.0 and 23.3.2, and the result was identical every time.
I also checked with pip install --no-cache-dir ..., and uv (0.2.15):

❯ uv pip install arm-pyart
Resolved 56 packages in 853ms
error: Failed to prepare distributions
  Caused by: Failed to fetch wheel: arm-pyart==1.18.5
  Caused by: Failed to extract archive
  Caused by: deflate decompression error

@neutrinoceros
Copy link
Contributor Author

Also:

  • installing from sdist with --no-binary arm-pyart works
  • note that I'm reproducing on Python 3.12. This seems actually crucial; I don't have any problem for 3.11 or 3.10

@mgrover1
Copy link
Collaborator

That makes more sense why I can't reproduce locally (I have an M1 Pro chip) - I am curious if this line in the cibuildwheel configuration could be to blame?
https://github.com/ARM-DOE/pyart/blob/main/.github/workflows/wheels.yml#L59C29-L59C52

@neutrinoceros
Copy link
Contributor Author

I doubt it. I don't think it changes the behavior of anything if binaries for your dependencies are available anyway.
But it might well be a bug in cibuildwheel itself, or its tool chain. I don't have time left to look it up today, but I might try to escalate this tomorrow (of course, feel free to beat me to it).

@mgrover1
Copy link
Collaborator

Okay - I will open an issue upstream! Thank you!

@mgrover1
Copy link
Collaborator

I appreciate the feedback here @neutrinoceros - the issue has been created, hopefully we can sort this out today!
pypa/cibuildwheel#1896

@mgrover1
Copy link
Collaborator

This should resolve the issue #1606

We were overwriting the built objects

@mgrover1
Copy link
Collaborator

A new version is being cut after tests run + pass +merge

@mgrover1
Copy link
Collaborator

@neutrinoceros - can you please try rerunning your CI with the new wheels released in the latest version?

@neutrinoceros
Copy link
Contributor Author

Done. All good. Thanks a lot !

@mgrover1
Copy link
Collaborator

Thank you! Keeping this closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants