Skip to content

Commit 35f1303

Browse files
committed
TODO: update tbb_spin_rw_mutex and jvm_objectmonitor
tbb_spin_rw_mutex using lock pointer: done ext/jvm/jvm_objectmonitor.h SpinPause(): done __cpu_relax() is called, so the USE_RELAX parameter sets what SpinPause does. Change-Id: I9f5710549f06fe51926a1795def1e2115d6506a3 Signed-off-by: James Yang <james.yang@arm.com>
1 parent ff6bc05 commit 35f1303

File tree

1 file changed

+1
-4
lines changed
  • benchmarks/lockhammer

1 file changed

+1
-4
lines changed

benchmarks/lockhammer/TODO

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Update SpinPause() in ext/jvm/jvm_objectmonitor.h
2929
- The SpinPause() function returns 0. However, this is only the case
3030
in now very old versions of OpenJDK. Modern versions use pause
3131
on 64-bit x86 (amd64) and a parameterized choice of a one or more
32-
ISB, or NOP on aarch64.
32+
ISB, or NOP on aarch64. (done)
3333

3434

3535
ext/linux/hybrid_spinlock*
@@ -38,9 +38,6 @@ ext/linux/hybrid_spinlock*
3838
queued_spinlock
3939
- queued_spinlock uses the lock pointer as well as mcs_pool, so need a way to have both be reproducible.
4040

41-
tbb_spin_rw_mutex
42-
- instead of doing operations on the state variable, use the test harness lock pointer for better reproducibility
43-
4441
clh_spinlock
4542
- instead of operating on global_clh_lock, use the test harness lock pointer for better reproducibility
4643

0 commit comments

Comments
 (0)