-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample applications should not set exit_code as return statement of functions #205
Comments
I have created the PR #221 to fix the issue reported here. |
@RonEld thank you for raising this issue.Please take a look at the following comments: Could you add some more detail to the description? A good description should be at least 25 words. NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'.This indicates to us that at least all the fields have been considered. |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
11 similar comments
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested? |
Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers. |
As commented in #199 (comment)
internal functions return code should be set to a variable different than
exit_code
.It's not a functionality bug, but it shows bad practice
The text was updated successfully, but these errors were encountered: