Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample applications should not set exit_code as return statement of functions #205

Open
RonEld opened this issue Oct 10, 2018 · 15 comments
Open

Comments

@RonEld
Copy link
Contributor

RonEld commented Oct 10, 2018

As commented in #199 (comment)
internal functions return code should be set to a variable different than exit_code.
It's not a functionality bug, but it shows bad practice

@andresag01
Copy link

I have created the PR #221 to fix the issue reported here.

@ciarmcom
Copy link
Member

@RonEld thank you for raising this issue.Please take a look at the following comments:

Could you add some more detail to the description? A good description should be at least 25 words.
What target(s) are you using?
What toolchain(s) are you using?
What version of Mbed OS are you using (tag or sha)?
It would help if you could also specify the versions of any tools you are using?
How can we reproduce your issue?

NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'.This indicates to us that at least all the fields have been considered.
Please update the issue header with the missing information, the issue will not be mirroredto our internal defect tracking system or investigated until this has been fully resolved.

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

11 similar comments
@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

ciarmcom commented Nov 4, 2020

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

ciarmcom commented Nov 9, 2020

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

ciarmcom commented Dec 5, 2020

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

@RonEld it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@ciarmcom
Copy link
Member

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-3114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants