-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update baud rate of CY8CKIT064B0S2_4343W to 115200 #14403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Mar 10, 2021
@saheerb, thank you for your changes. |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Mar 11, 2021
Reopening in a minute, let Travis to rebuild this and we can merge. |
mergify
bot
removed
component: core
needs: review
release-type: patch
Indentifies a PR as containing just a patch
labels
Mar 11, 2021
queued ! :-) |
0xc0170
added
devices: cypress
release-type: patch
Indentifies a PR as containing just a patch
ready for merge
labels
Mar 11, 2021
This was referenced Mar 14, 2021
This was referenced Mar 16, 2021
mbedmain
removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Currently, greentea tests are built with 9600 baudrate. When greentea tests are built for CY8CKIT064B0S2_4343W , the result binaries are combined with a cypress bootloader which is built with 115200. This mismatch in bootloader and application causes a "unicode decode" error in greentea while parsing the serial output. Though when running locally this seems not an issue, when running against devices in our hardware farm this is causing a failure in greentea.
Hence, this PR will update the baud rate of CY8CKIT064B0S2_4343W to 115200.
/!\ We do have an internal ticket to update default baudrate to 115200. As it is a breaking change this will be done only for mbed-os-7
Impact of changes
None that I am ware of.
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/team-cypress