STM32: AnalogOut: do not call HAL_DAC_Start in dac_write #14423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac_write (used by AnalogOut.write) calls HAL_DAC_Start every time. It is required to call HAL_DAC_Start only once. HAL_DAC_Start uses internally HAL_Delay(1) making AnalogOut not suitable for use in high speed application. This change removes call to HAL_DAC_Start in dac_write and moves it to analogout_init.
ciarmcom
added
the
release-type: patch
|
@mczerski, thank you for your changes. |
jeromecoutant
approved these changes
Mar 12, 2021
0xc0170
approved these changes
Mar 12, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
This was referenced Mar 14, 2021
This was referenced Mar 16, 2021
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
dac_write (used by AnalogOut.write) calls HAL_DAC_Start
every time. It is required to call HAL_DAC_Start only once.
HAL_DAC_Start uses internally HAL_Delay(1) making AnalogOut
not suitable for use in high speed application.
This change removes call to HAL_DAC_Start in dac_write and
moves it to analogout_init.
Impact of changes
Call to AnalogOut.write for STM32 is at least 1ms faster.
Documentation
None
Pull request type
Test results
Tested on STM32G474RE with oscilloscope by generating "sawtooth" signal.