Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical - core_util_atomic_decr/incr are undefined #2126

Closed
0xc0170 opened this issue Jul 8, 2016 · 5 comments
Closed

Critical - core_util_atomic_decr/incr are undefined #2126

0xc0170 opened this issue Jul 8, 2016 · 5 comments

Comments

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2016

Undefined functions core_util_atomic_decr/incr. There's no function with a declaration to match: core_util_atomic_decr((uintptr_t)valuePtr, (uintptr_t)delta) . I would assume that missing functions should be implemented, and can't be on top of current functions because they return a value, and these functions return void pointer. The API documentation should state that (be more specific), not The new decremented value. as the rest of API.

Reference: #2054

@geky

@LMESTM
Copy link
Contributor

LMESTM commented Jul 8, 2016

I'm facing this issue as well on top of today's mbed/master ... it seems to happen "only" on cortex-M0/M0+ targets.
Has this pass through CI compilation ?

@geky
Copy link
Contributor

geky commented Jul 8, 2016

Pr up: #2131. It was a last minute change and went unnoticed since GCC only emits a warning.

can't be on top of current functions because they return a value, and these functions return void pointer

That is my bad, I was missing the warning emitted for differing return values. I'll fix this in a separate pr once #2131 is merged.

@geky
Copy link
Contributor

geky commented Jul 8, 2016

Due to IAR errors I went ahead and fixed the casting issue @0xc0170 noticed on #2131. Let me know if there's still an issue.

@geky
Copy link
Contributor

geky commented Jul 11, 2016

Now that #2131 is merged, is this still an issue?

@ciarmcom
Copy link
Member

ciarmcom commented Aug 1, 2016

ARM Internal Ref: IOTMORF-135

@sg- sg- removed the mirrored label Aug 12, 2016
@sg- sg- closed this as completed Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants