Skip to content

[Exporters] make_gcc_arm doesn't use definitions in the default profile #3890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan- opened this issue Mar 6, 2017 · 10 comments
Closed

[Exporters] make_gcc_arm doesn't use definitions in the default profile #3890

pan- opened this issue Mar 6, 2017 · 10 comments

Comments

@pan-
Copy link
Member

pan- commented Mar 6, 2017

Description


Bug

Target ALL

Toolchain: GCC_ARM

mbed-cli version: 1.0.0

meed-os sha: 3a27568

Expected behavior Binary resulting from and export with make_gcc_arm should be similar to a binary compiled with mbed compile -t GCC_ARM

Actual behavior The default toolchain profile (develop) is not used by the exporter and as a result, the optimization flag is set to -O0 instead of -Os.

Steps to reproduce: see ARMmbed/mbed-os-example-ble#61

@pan-
Copy link
Member Author

pan- commented Mar 6, 2017

@theotherjimmy

@theotherjimmy
Copy link
Contributor

The profile is set to debug. you can change it with the --profile develop command line option.

@theotherjimmy
Copy link
Contributor

I am working on a PR that will have exporters use all built-in profiles. I think that should resolve this issue, when it happens.

@pan-
Copy link
Member Author

pan- commented Mar 7, 2017

The profile is set to debug. you can change it with the --profile develop command line option.

The default profile used during compilation by mbed-cli is develop, why it has to be different for this exporter ? Can it be documented somewhere (or align with mbed compile) ?

@theotherjimmy
Copy link
Contributor

It's not different for this exporter. It's different for all exporters.

@sg-
Copy link
Contributor

sg- commented Mar 8, 2017

This has always been the intention. When exporting you are taking advantage of debug capabilities therefore, getting default setting that are debug friendly is the default.

We should add a note to the docs about exporters and close this issue.

@MarceloSalazar
Copy link

Can someone please take an action and/or confirm the (doc) fix / PR for this?

@pan-
Copy link
Member Author

pan- commented Mar 10, 2017

We should add a note to the docs about exporters and close this issue.

As an example maintainer, I would really appreciate to have more details in the handbook about the exporters behavior, differences with mbed-cli, IDE versions targeted and possible corner cases.

With such information I can point users of my example to an always up to date, complete documentation rather by "patching" the example documentation with partial information which might be outdated the next release.

@theotherjimmy
Copy link
Contributor

@pan- I will add some documentation for exporters in general. When I do, I will close this issue.

@theotherjimmy
Copy link
Contributor

Documentation added. Please follow up discussion in ARMmbed/mbed-os-5-docs#151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants