-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing filesystem tests due to memory allocation #7712
Comments
One way to handle this, as suggested by @SenRamakri , is that we over-write the mbed-os error handler with a dummy procedure that does nothing when the call to "new" fails. Here is the snippet of what code would look like (with some commentary about the changes)
However, this change is only needed for some specific parts, and tool chain. Like the test, features-tests-filesystem-buffered_block_device is failing for WIZWIKI_W7500 on GCC_ARM toolchain. Adding the code snippet above can/will mask failures for other devices that do not need this change in. So, making this change would require having some more ifdef in the test script, and to me it looks like we are entering into a new territory of modifying the test according to specific part numbers which doesn't look as appealing. |
ARM Internal Ref: MBOTRIAGE-1496 |
Why is it failing? not enough memory? There's 48 kB SRAM (if no socket are used, not sure if these are allocated by default) |
@aashishc1988 The test you are running does not match the output. |
Just to add: |
Closing as duplicate, lets continue in 7535 and close that one |
@davidsaada My bad, I pasted the wrong output. I was filing multiple issues and got confused. Sorry about that. Please take a look at the updated log. The current test runs with |
re-opening as per above comment from @aashishc1988 |
@aashishc1988 This issue found me asking the following questions:
|
@davidsaada I am little unfamiliar with all the terms and environment setup. I will try my best to answer questions to the best of my knowledge and will also tag relevant people.
|
Regarding 3: Yes - I'm using the same flags as you do. I simply copied your command (with the exception I broke it to two, in order to run it on a remote board). I am seeing the Regarding 4: it's the same as yours, but instead of |
Interesting. |
Well. I am updated with the latest mbed-os changes. In addition, I'm pretty sure that the PR that included the std::nothrow changes has passed CI with the error handling mechanism already in (it is fairly new). I really don't know what to say. Only way I can tackle it is if I reproduce it, something that didn't happen yet. |
@davidsaada Can you point me to the CI test log where it passed so that i can compare what is different between the two setups? It's possible that I might be missing something here. |
@davidsaada Can you also try this: and see if you can reproduce the error |
Thanks @aashishc1988. I have managed to reproduce the problem with your command. Apparently, it has nothing to do with the |
@aashishc1988 #7730 should fix it. Please verify. |
@davidsaada #7730 fixes it. Thanks for investigating (and fixing) it :) |
@aashishc1988 Thanks for verifying. That PR still needs some work, but glad it's in the right direction. |
Description
Bug
Target
WIZWIKI_W7500
Toolchain:
GCC_ARM
Tests we are failing:
features-tests-filesystem-buffered_block_device
Steps to reproduce
mbed test -m WIZWIKI_W7500 -t IAR -n features-tests-filesystem-buffered_block_device -DMBED_HEAP_STATS_ENABLED=1 -DMBED_TRAP_ERRORS_ENABLED=1 -v
So, it seems that the call to new would fail, and even though we have nothrow exception defined, the mbed-os error handler is not very forgiving. The failure gets trapped by the error handler.
log snippet
The text was updated successfully, but these errors were encountered: