Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.x: Allow configuring MBEDTLS_TLS_EXT_CID at compile time #4427

Merged

Conversation

gilles-peskine-arm
Copy link
Contributor

The numerical identifier of the CID extension hasn't been settled yet and different implementations use values from different drafts. Allow configuring the value at compile time as discussed in #3892 (comment).

This PR is for 2.x. 3.0 PR

The numerical identifier of the CID extension hasn't been settled yet
and different implementations use values from different drafts. Allow
configuring the value at compile time.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added mbed TLS team needs-review Every commit must be reviewed by at least two team members, component-tls needs-reviewer This PR needs someone to pick it up for review labels Apr 27, 2021
@gilles-peskine-arm gilles-peskine-arm changed the base branch from development to development_2.x April 27, 2021 09:36
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a faithful backport.

@mpg
Copy link
Contributor

mpg commented Apr 27, 2021

This is a straighforward backport so it only needs one approval, adjusting the labels accordingly.

@mpg mpg removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 27, 2021
@mpg mpg removed the request for review from hanno-becker April 27, 2021 09:41
@TRodziewicz TRodziewicz added the single-reviewer This PR qualifies for having only one reviewer label Jul 21, 2021
@mpg mpg added the needs-ci Needs to pass CI tests label Aug 13, 2021
@mpg
Copy link
Contributor

mpg commented Aug 13, 2021

The CI fully passed, but for some reason status has not been updated on github.

@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-ci Needs to pass CI tests labels Aug 13, 2021
@mpg mpg merged commit f87422f into Mbed-TLS:development_2.x Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports component-tls single-reviewer This PR qualifies for having only one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants