-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Docker (and other?) actions fork-safe #47
Comments
Fixed in #57 |
Example of pushing and tagging successfully (on a non-fork repo): https://github.com/ASFHyP3/hyp3-ci/actions/runs/4388321365/jobs/7684692901 |
I merged a PR from my fork of I'm not sure if I'm taking the correct steps to reproduce the original bug. I'm reopening this issue until we've confirmed that the fix works. |
Confirm it does work as expected here: https://github.com/ASFHyP3/hyp3-ci/pull/7 If you use the |
The docker build action always tries to push to GHCR, and thus will fail for forks as they don't have permission to push to GHCR. We should either figure out how to allow pushes from forks (maybe not the best idea from a sec perspective!) or skip the push action for forks.
The text was updated successfully, but these errors were encountered: