Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker (and other?) actions fork-safe #47

Closed
jhkennedy opened this issue Dec 7, 2022 · 4 comments · Fixed by #59
Closed

Make Docker (and other?) actions fork-safe #47

jhkennedy opened this issue Dec 7, 2022 · 4 comments · Fixed by #59

Comments

@jhkennedy
Copy link
Contributor

The docker build action always tries to push to GHCR, and thus will fail for forks as they don't have permission to push to GHCR. We should either figure out how to allow pushes from forks (maybe not the best idea from a sec perspective!) or skip the push action for forks.

@jhkennedy
Copy link
Contributor Author

Fixed in #57

@jtherrmann
Copy link
Contributor

Example of pushing and tagging successfully (on a non-fork repo): https://github.com/ASFHyP3/hyp3-ci/actions/runs/4388321365/jobs/7684692901

@jtherrmann jtherrmann reopened this Mar 10, 2023
@jtherrmann
Copy link
Contributor

I merged a PR from my fork of hyp3-ci but it looks like there are still failing actions: https://github.com/ASFHyP3/hyp3-ci/actions

I'm not sure if I'm taking the correct steps to reproduce the original bug. I'm reopening this issue until we've confirmed that the fix works.

@jhkennedy
Copy link
Contributor Author

Confirm it does work as expected here: https://github.com/ASFHyP3/hyp3-ci/pull/7

If you use the GITHUB_TOKEN; will update the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants