Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DepClean doesn't fully extract JAR content when the extraction of a single file fails #47

Closed
mtorres10 opened this issue Mar 18, 2021 · 3 comments
Closed

DepClean doesn't fully extract JAR content when the extraction of a single file fails #47

mtorres10 opened this issue Mar 18, 2021 · 3 comments
Assignees
@cesarsotovalero
Labels
bug Something isn't working

Comments

@mtorres10
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When analyzing for some dependencies, for example selenium (see #46) due an odd jar structure depclean does not fully extract jar contents, so not all classes are analized

Describe the solution you'd like
Allow the extraction of files to continue, and print a warning of which file caused an issue.
@mtorres10 mtorres10 added the feature New feature request label Mar 18, 2021
@mtorres10
Copy link
Contributor Author

PR for this feature request is here

@mtorres10 mtorres10 changed the title [FEATURE] Continue with jar files extraction even when a single file fails Continue with jar files extraction even when a single file fails Mar 18, 2021
@cesarsotovalero cesarsotovalero self-assigned this Mar 18, 2021
@cesarsotovalero cesarsotovalero added bug Something isn't working and removed feature New feature request labels Mar 18, 2021
@cesarsotovalero cesarsotovalero changed the title Continue with jar files extraction even when a single file fails DepClean doesn't fully extract JAR content when the extraction a single file fails Mar 18, 2021
@cesarsotovalero cesarsotovalero changed the title DepClean doesn't fully extract JAR content when the extraction a single file fails DepClean doesn't fully extract JAR content when the extraction of a single file fails Mar 18, 2021
@cesarsotovalero
Copy link
Collaborator

Thank @mtorres10. I reviewed your PR. Please remove all the changes that are not related to the fix, as I mentioned in the review. Once you do that, I'll accept your PR.

@mtorres10
Copy link
Contributor Author

@cesarsotovalero PR has been fixed as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cesarsotovalero cesarsotovalero

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cesarsotovalero @mtorres10