Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows #273

Closed
2 tasks
khesoem opened this issue Dec 7, 2020 · 8 comments · Fixed by #704
Closed
2 tasks

Add support for Windows #273

khesoem opened this issue Dec 7, 2020 · 8 comments · Fixed by #704
Assignees
Labels
enhancement New feature or request

Comments

@khesoem
Copy link
Collaborator

khesoem commented Dec 7, 2020

There are some tests that do not pass on Windows because of the difference between file paths in windows and linux. For example, sorald.processor.ProcessorTest.

  • fix the tests on Windows
  • add Windows CI
@khesoem khesoem added the bug Something isn't working label Dec 7, 2020
@khesoem khesoem self-assigned this Dec 7, 2020
@slarse
Copy link
Collaborator

slarse commented Dec 8, 2020

I wasn't aware that we support Windows. If that's the case, we must also run CI for Windows. It's not just about filepaths, Windows uses a file system that differs quite a lot from those found in Unix-like systems. Permissions are especially a pain, and I've had massive trouble with temporary files and directories before (which Sorald uses a lot both in testing and production).

@khesoem
Copy link
Collaborator Author

khesoem commented Dec 8, 2020

I wasn't aware that we support Windows

Actually, I'm not sure if we want to support Windows for users either. But it would be nice to, at least, make the tests pass so that developers who user Windows (like me :D) can ensure tests pass locally before pushing it on Github.

@slarse
Copy link
Collaborator

slarse commented Dec 8, 2020

I think we should discuss this at the meeting. Due to how dependent Sorald is on file system interaction, supporting Windows might be an added cost that we don't want to have.

As for local development, have you considered Windows Subsystem for Linux (2)? You'd definitely be able to run the tests in there.

@slarse
Copy link
Collaborator

slarse commented Dec 8, 2020

On a side note, Windows is the most popular dev platform according to the SO survey, so if we want to have a lot of end users of Sorald (as opposed to running it with e.g. Repairnator), we should probably at least attempt to support Windows.

@khesoem
Copy link
Collaborator Author

khesoem commented Dec 8, 2020

have you considered Windows Subsystem for Linux (2)?

Not really! I will give it a try. Thanks for the suggestion.

@monperrus monperrus changed the title All tests should pass on Windows as well add support for Windows Dec 9, 2020
@slarse slarse changed the title add support for Windows Add support for Windows Dec 9, 2020
@monperrus monperrus added enhancement New feature or request and removed bug Something isn't working labels Dec 9, 2020
@slarse
Copy link
Collaborator

slarse commented Jan 28, 2021

Just for the record, we've decided to add Windows support in the coming months. It's just not quite at the top of the priority list at the moment :)

@slarse
Copy link
Collaborator

slarse commented Feb 5, 2021

It would probably be helpful to fix #166 first, as using filepaths as strings is a massive complication for supporting different file systems.

@slarse
Copy link
Collaborator

slarse commented Aug 17, 2021

We have partial Windows support as of #591, but there are still a few test failures. These are ignored with DisabledOnOs(OS.WINDOWS) markers followed by a FIXME comment. We'll want to fix these before stating that we have full Windows support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants