-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Windows #273
Comments
I wasn't aware that we support Windows. If that's the case, we must also run CI for Windows. It's not just about filepaths, Windows uses a file system that differs quite a lot from those found in Unix-like systems. Permissions are especially a pain, and I've had massive trouble with temporary files and directories before (which Sorald uses a lot both in testing and production). |
Actually, I'm not sure if we want to support Windows for users either. But it would be nice to, at least, make the tests pass so that developers who user Windows (like me :D) can ensure tests pass locally before pushing it on Github. |
I think we should discuss this at the meeting. Due to how dependent Sorald is on file system interaction, supporting Windows might be an added cost that we don't want to have. As for local development, have you considered Windows Subsystem for Linux (2)? You'd definitely be able to run the tests in there. |
On a side note, Windows is the most popular dev platform according to the SO survey, so if we want to have a lot of end users of Sorald (as opposed to running it with e.g. Repairnator), we should probably at least attempt to support Windows. |
Not really! I will give it a try. Thanks for the suggestion. |
Just for the record, we've decided to add Windows support in the coming months. It's just not quite at the top of the priority list at the moment :) |
It would probably be helpful to fix #166 first, as using filepaths as strings is a massive complication for supporting different file systems. |
We have partial Windows support as of #591, but there are still a few test failures. These are ignored with |
There are some tests that do not pass on Windows because of the difference between file paths in windows and linux. For example,
sorald.processor.ProcessorTest
.The text was updated successfully, but these errors were encountered: