Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review underscores in wc_strs for params #1

Open
Fedorov113 opened this issue Jun 10, 2019 · 1 comment
Open

Review underscores in wc_strs for params #1

Fedorov113 opened this issue Jun 10, 2019 · 1 comment

Comments

@Fedorov113
Copy link
Collaborator

Fedorov113 commented Jun 10, 2019

Parameters are stored inside json/yaml files inside assnake_db. Assnake determines which parameters to use from the wildcard_str (.../tmtic_{params}/..). File that contains this parameters is taken from assnake_db by its name.

Q: Should we store this file also inside the folder with generated results?
A: I think yes, this way the file can be pushed to git and it will be easier to get it for higher order system. Also parameters will be saved if the assnake_db will be deleted.

We also should we able to pickup this file from result folder and put it into db. If the name is not unique and the contents of params.yaml file is different, for now just add counter like params1.yaml

Should we store params not by name but by short hash? It will help to avoid non unique names problem, but at the same time reduce human readability. Since we will store params with uuid-v4 in higher order system anyway, there is no much sense in it.

@Fedorov113
Copy link
Collaborator Author

We store params with computed CRC32 hash in filename, like {params_name}.{hash}.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant