Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Model hashes begin to repeat #4298

Closed
1 task done
Jonseed opened this issue Nov 4, 2022 · 8 comments
Closed
1 task done

[Bug]: Model hashes begin to repeat #4298

Jonseed opened this issue Nov 4, 2022 · 8 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@Jonseed
Copy link

Jonseed commented Nov 4, 2022

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

I have four ckpt models that all show the very same hash. They are, of course, different files.

Steps to reproduce the problem

  1. Put several models in the SD model folder
  2. Reload models
  3. Several of the models show the same hash

What should have happened?

They should have unique hashes.

Commit where the problem happens

d61f0de

What platforms do you use to access UI ?

Windows

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

--xformers --autolaunch --gradio-img2img-tool color-sketch

Additional information, context and logs

How do you get the server to reassign hashes?

@Jonseed Jonseed added the bug-report Report of a bug, yet to be confirmed label Nov 4, 2022
@zzhongzz
Copy link

zzhongzz commented Nov 8, 2022

I experience the same issue.
I think becuase it only calculates model hash only from the first 0x10000 bytes at offset 0x100000, as shown here.
So if two models have the same content in this region, they will show the same hash, which is quite common in merged checkpoints.

@Jonseed
Copy link
Author

Jonseed commented Nov 8, 2022

Hmm, yeah, that's probably the reason we're seeing duplicate hashes. It needs to read more of the ckpt file or calculate the hash differently to generate a unique hash.

@jn-jairo
Copy link
Collaborator

jn-jairo commented Nov 9, 2022

I made a PR #2459 about that, feel free to take a look.

@trojblue
Copy link

trojblue commented Nov 26, 2022

image

It's really a big issue here. literally 75% of my models have duplicate hashes rn

@Jonseed
Copy link
Author

Jonseed commented Nov 27, 2022

PR #4546 would fix it.

@0xdevalias
Copy link

0xdevalias commented Nov 27, 2022

PR #4546 would fix it.

As would this one, which came first:

@jn-jairo
Copy link
Collaborator

Issue solved by a95f135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

5 participants