Recorder and Subscribed C messages

[bbercoviciUspace]

Hello everyone,

I'm basically cross-referencing two issues I created on the issue page (@patkenneally , @schaubh , let me know if you'd like these discussions to solely remain on the discussion page).

I stumbled upon two aspects of the Recorders when used in conjunction with C messages which I believe are not a desired design feature :

1. Subscribed (aka C 'Readers') C-messages can't be recorded because the Recorder constructor reads in the wrong pointer (one that points at the payload field of the message structure, instead of the payloadPointer field, which is the one that actually leads to the written in data). The recorder tied to such a subscribed C-message is thus always recording a zero message payload (the content of the payload field). I think the overall intended behavior for Recorders and subscribed C messages, should be that the recorder hooked to the subscribed C-message should record the same data as a recorder hooked to the message the C-message is subscribed to.

2. The wrong message header is passed to the Recorder constructor. At minimum, this means that the recorder is filled with bogus information from this header. I think this issue affects both self-author and subscribed C messages.