Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG Issues #91

Closed
R-Ramana opened this issue Mar 30, 2023 · 4 comments
Closed

DG Issues #91

R-Ramana opened this issue Mar 30, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@R-Ramana
Copy link

Good Effort on the DG! I have listed some feedback for the DG

  1. Should commons be referenced by something, like Main maybe?

image

  1. This is a non-standard representation of the class diagram. Refer here to update. Same for subsequent class diagrams

image

  1. Try not to put the description in the middle, it is rather ambiguous as to where it belongs.

image

  1. I think there are missing colons in the sequence diagrams and under the UI, the activation bar needs to be completely started. Likewise in the subsequent diagrams.

image

  1. Self-invocation is missing an activation bar and I am unsure what the floating arrows are pointing to. This is recurring in the other sequence diagrams as well.

image

  1. Unsure about the following. I believe they arose from merge conflicts, please ensure they are removed.

image

image

@bentohset
Copy link

bentohset commented Mar 30, 2023

@R-Ramana For no. 3, how do you put the description at the head of the arrow for plantUML?

@bentohset bentohset self-assigned this Mar 30, 2023
@bentohset
Copy link

Current fix #92

@bentohset bentohset added this to the v2.1 milestone Mar 30, 2023
@bentohset bentohset added the type.Bug A bug label Mar 30, 2023
@R-Ramana
Copy link
Author

R-Ramana commented Mar 30, 2023

@R-Ramana For no. 3, how do you put the description at the head of the arrow for plantUML?

Refer to section 3.2

image

@bentohset
Copy link

#92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants