MatSelect fix #1248
Merged
MatSelect fix #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://test-deployment-pr-1248.herokuapp.com/ |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.6.0-master.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue: #1244
Background: Angular compares the value of a
MatSelectwith the options that are available in order to find the one that is currently selected. In our case both these values are loaded from the config but in some cases the config changes and therefore the objects might have different references. In this case Angular is not able to match the selected value with the options and does not display anything.[compareWith]allows to overwrite this behavior which we can use to compare the enum values more deeply (source).Visible/Frontend Changes
MatSelectwith configurable enum are correctly displayed when page has just loaded.Architectural/Backend Changes
compareWithto correctly match options to values inMatSelect