Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Showing error message when entering a invalid date #1251

Merged
merged 4 commits into from
May 5, 2022
Merged

fix: Showing error message when entering a invalid date #1251

merged 4 commits into from
May 5, 2022

Conversation

TheSlimvReal
Copy link
Collaborator

see issue: #1182

Visible/Frontend Changes

  • Entering a invalid date shows a error message in the datepicker

Architectural/Backend Changes

--

@github-actions
Copy link

github-actions bot commented May 5, 2022

Deployed to https://test-deployment-pr-1251.herokuapp.com/

Schottkyc137
Schottkyc137 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@Schottkyc137 Schottkyc137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a clean one-line solution.
However, we should probably think of a better way to deal with builtin validators like this because the current approach will fail on all predefined validators. Maybe a simple Field Invalid with a log is better here?

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal
Copy link
Collaborator Author

@Schottkyc137 A general solution would be great but to have a user friendly error message at the same time will be difficult. A log is not really necessary as this should mostly point users towards input errors and not necessarily a problem on our side

@TheSlimvReal TheSlimvReal merged commit fa190d2 into master May 5, 2022
@TheSlimvReal TheSlimvReal deleted the datepicker-error-fix branch May 5, 2022 19:35
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.6.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schottkyc137 Schottkyc137 Schottkyc137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSlimvReal @aam-digital-ci @Schottkyc137