Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding remarks doesn't enable the 'save' button in note details #1294

Closed
TheSlimvReal opened this issue May 27, 2022 · 3 comments
Closed

Adding remarks doesn't enable the 'save' button in note details #1294

TheSlimvReal opened this issue May 27, 2022 · 3 comments
Labels
Type: Bug

Comments

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented May 27, 2022 •
edited
Loading

To Reproduce
Steps to reproduce the behavior:

  1. Record attendance with the role call
  2. Click on 'Review details' once done
  3. Add remarks
  4. The save button is still disabled

Expected behavior
The save button should be enabled because the note has been edits

Additional context
This might happen because the note is not correctly copied or because the form-dirty check is not done on all sub-forms
@TheSlimvReal TheSlimvReal mentioned this issue May 27, 2022
Merged
@sleidig sleidig moved this to Triage in All Tasks & Issues May 30, 2022
@sleidig sleidig moved this to In Progress in Important Fixes & Enhancements May 30, 2022
@sleidig sleidig closed this as completed in e823c82 Jun 3, 2022
Repository owner moved this from In Progress to Done in Important Fixes & Enhancements Jun 3, 2022
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.6.2-master.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.6.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
No open projects
Important Fixes & Enhancements
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheSlimvReal @aam-digital-ci